[tools] backport_node.py increments V8 version in target.

[tools] backport_node.py increments V8 version in target.

R=franzih@chromium.org, machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2846883002
Cr-Commit-Position: refs/heads/master@{#44943}
Committed: https://chromium.googlesource.com/v8/v8/+/2b7a431ea34474709faeaff22db076cdbafc4597

[Yang, 2017-04-27 13:01:09]

Please take a look!

[Michael Achenbach, 2017-04-27 13:22:05]

lgtm with comments:

I assume we'll get a merge conflict each time V8's version file changes on
master? We do this once per milestone and set e.g. V8 version:
5.8.0 -> 5.9.0

I assume node would then only increment the patch level and never the build
level? E.g. end up with 5.9.0.123?

https://codereview.chromium.org/2846883002/diff/1/tools/release/backport_node.py
File tools/release/backport_node.py (right):

https://codereview.chromium.org/2846883002/diff/1/tools/release/backport_node...
tools/release/backport_node.py:28: import re
nit: sort imports, separate local imports with an empty line

[Yang, 2017-04-27 14:18:58]

Thanks for the review!

I don't think there will be a merge conflict. We would simply bump up the patch
level regardless of whether v8-version.h has been updated from V8 upstream or
not. I also don't think we will ever run into the situation of back porting the
patch that bumps the V8 version.

https://codereview.chromium.org/2846883002/diff/1/tools/release/backport_node.py
File tools/release/backport_node.py (right):

https://codereview.chromium.org/2846883002/diff/1/tools/release/backport_node...
tools/release/backport_node.py:28: import re
On 2017/04/27 13:22:04, Michael Achenbach wrote:
> nit: sort imports, separate local imports with an empty line

Done.

[Yang, 2017-04-27 14:19:49]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-27 14:19:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2846883002/#ps20001
(title: "sort imports")

[commit-bot: I haz the power, 2017-04-27 14:19:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-04-27 14:28:33]

lgtm

[commit-bot: I haz the power, 2017-04-27 14:50:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493302789384110,
"parent_rev": "1dfcc4b6876d866e803b0a0af05bd27418443cbe", "commit_rev":
"2b7a431ea34474709faeaff22db076cdbafc4597"}

[commit-bot: I haz the power, 2017-04-27 14:50:17]

Description was changed from

==========
[tools] backport_node.py increments V8 version in target.

R=franzih@chromium.org, machenbach@chromium.org
==========

to

==========
[tools] backport_node.py increments V8 version in target.

R=franzih@chromium.org, machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2846883002
Cr-Commit-Position: refs/heads/master@{#44943}
Committed:
https://chromium.googlesource.com/v8/v8/+/2b7a431ea34474709faeaff22db076cdbaf...
==========

[commit-bot: I haz the power, 2017-04-27 14:50:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2b7a431ea34474709faeaff22db076cdbaf...