Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2846793002:
Remove Resource::CurrentAge and Resource::FreshnessLifetime (Closed)
|
Created:
3 years, 7 months ago by yhirano Modified:
3 years, 7 months ago Reviewers:
hiroshige CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove Resource::CurrentAge and Resource::FreshnessLifetime
They are not used by anyone.
BUG=None
Review-Url: https://codereview.chromium.org/2846793002
Cr-Commit-Position: refs/heads/master@{#467906}
Committed: https://chromium.googlesource.com/chromium/src/+/892b284a813d8ba38a64e64c6f96ff753063a9b2
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : fix #
Messages
Total messages: 31 (24 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove Resource::CurrentAge nad Resource::FreshnessLifetime They are not used by anyone. BUG=None ========== to ========== Remove Resource::CurrentAge nad Resource::FreshnessLifetime They are not used by anyone. BUG=None ==========
yhirano@chromium.org changed reviewers: + hiroshige@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
lgtm
On 2017/04/27 19:43:10, hiroshige wrote: > lgtm > CL Description s/nad/and/
On 2017/04/27 19:43:10, hiroshige wrote: > lgtm > CL Description s/nad/and/
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== Remove Resource::CurrentAge nad Resource::FreshnessLifetime They are not used by anyone. BUG=None ========== to ========== Remove Resource::CurrentAge and Resource::FreshnessLifetime They are not used by anyone. BUG=None ==========
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
On 2017/04/27 19:43:27, hiroshige wrote: > On 2017/04/27 19:43:10, hiroshige wrote: > > lgtm > > > CL Description > s/nad/and/ Done, thanks!
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hiroshige@chromium.org Link to the patchset: https://codereview.chromium.org/2846793002/#ps40001 (title: "fix")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493351765232150,
"parent_rev": "ff3d745c3a244f84d791ea20bd70dd3c9b86a160", "commit_rev":
"892b284a813d8ba38a64e64c6f96ff753063a9b2"}
Message was sent while issue was closed.
Description was changed from ========== Remove Resource::CurrentAge and Resource::FreshnessLifetime They are not used by anyone. BUG=None ========== to ========== Remove Resource::CurrentAge and Resource::FreshnessLifetime They are not used by anyone. BUG=None Review-Url: https://codereview.chromium.org/2846793002 Cr-Commit-Position: refs/heads/master@{#467906} Committed: https://chromium.googlesource.com/chromium/src/+/892b284a813d8ba38a64e64c6f96... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/892b284a813d8ba38a64e64c6f96... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
