Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2846763004: Revert of Roll ANGLE f584177..e8b3551 (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ANGLE f584177..e8b3551 (patchset #1 id:1 of https://codereview.chromium.org/2849583003/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 467881 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZhMGE3ZTY2ZGQxNTgzYWI3MTQzNmYyNmVlMzYyMjc4NDM3ZTE5NzIM Original issue's description: > Roll ANGLE f584177..e8b3551 > > https://chromium.googlesource.com/angle/angle.git/+log/f584177..e8b3551 > > BUG=715875, 705865 > TBR=jmadill@chromium.org, geofflang@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2849583003 > Cr-Commit-Position: refs/heads/master@{#467881} > Committed: https://chromium.googlesource.com/chromium/src/+/fa0a7e66dd1583ab71436f26ee362278437e1972 TBR=jmadill@chromium.org,geofflang@chromium.org,ynovikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715875, 705865 Review-Url: https://codereview.chromium.org/2846763004 Cr-Commit-Position: refs/heads/master@{#467886} Committed: https://chromium.googlesource.com/chromium/src/+/b96dfa5b9c0656cc9a8dc0e67f1ab3b547c45a84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
findit-for-me
Created Revert of Roll ANGLE f584177..e8b3551
3 years, 7 months ago (2017-04-28 04:13:55 UTC) #1
skobes
lgtm
3 years, 7 months ago (2017-04-28 04:51:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846763004/1
3 years, 7 months ago (2017-04-28 04:51:52 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 04:53:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b96dfa5b9c0656cc9a8dc0e67f1a...

Powered by Google App Engine
This is Rietveld 408576698