Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2846763002: Update progress center immediately when files are pasted. (Closed)

Created:
3 years, 7 months ago by tetsui2
Modified:
3 years, 7 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update progress center immediately when files are pasted. URLsToEntriesWithAccess is heavy operation especially on slow storage devices such as MTP connected ones. Previously, progress center was updated only after URLsToEntriesWithAccess was finished. As a result, it took more than 30 seconds for a user to receive feedback in some cases. BUG=712547 TEST=manually tested. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2846763002 Cr-Commit-Position: refs/heads/master@{#467840} Committed: https://chromium.googlesource.com/chromium/src/+/eab6fcca575e4781af96c9f1b81265e05f370744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tetsui2
Please take a look! Thank you!
3 years, 7 months ago (2017-04-27 05:53:00 UTC) #7
fukino
lgtm. Thanks!
3 years, 7 months ago (2017-04-27 09:42:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846763002/1
3 years, 7 months ago (2017-04-28 02:02:22 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 02:13:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eab6fcca575e4781af96c9f1b812...

Powered by Google App Engine
This is Rietveld 408576698