Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2846723004: Use ScopedTaskEnvironment instead of MessageLoopForUI in ash tests. (Closed)

Created:
1 year, 10 months ago by fdoray
Modified:
1 year, 10 months ago
Reviewers:
gab, sky
CC:
chromium-reviews, kalyank, sadrul, derat+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoopForUI in ash tests. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 R=gab@chromium.org TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2846723004 Cr-Commit-Position: refs/heads/master@{#467987} Committed: https://chromium.googlesource.com/chromium/src/+/40b0d9cabbed3a1447f51af3ffc5a287e86f9390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M ash/system/power/power_status_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M ash/test/ash_test_environment_default.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
1 year, 10 months ago (2017-04-27 18:27:18 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
1 year, 10 months ago (2017-04-27 18:27:21 UTC) #3
sky
LGTM
1 year, 10 months ago (2017-04-27 22:14:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846723004/1
1 year, 10 months ago (2017-04-28 13:51:35 UTC) #9
commit-bot: I haz the power
1 year, 10 months ago (2017-04-28 14:12:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40b0d9cabbed3a1447f51af3ffc5...

Powered by Google App Engine
This is Rietveld 408576698