Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py

Issue 2846723003: Removed local RefPtr created from PassRefPtr arg in generated file. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py
diff --git a/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py b/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py
index d769096f565788201878459b2500e88ca5fc5e2d..c9577c9e82a1034da219b22a216eb6df0d910907 100644
--- a/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py
+++ b/third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py
@@ -155,11 +155,9 @@ class Parameter(object):
self.type = param_decl
self.name = build_param_name(self.type)
- self.value = self.name
- self.is_prp = re.match(r"PassRefPtr<", param_decl) is not None
- if self.is_prp:
- self.name = "prp" + self.name[0].upper() + self.name[1:]
- self.inner_type = re.match(r"PassRefPtr<(.+)>", param_decl).group(1)
+ self.is_rp = re.match(r"RefPtr<", param_decl) is not None
alph 2017/04/27 22:57:04 doesn't seems to be used outside the function.
+ if self.is_rp:
+ self.name = "rp" + self.name[0].upper() + self.name[1:]
alph 2017/04/27 22:57:04 In fact, you don't really need to mangle the name
Bugs Nash 2017/04/27 23:05:59 Nope, I just thought rpInnerTypeName was more read
if self.type[-1] == "*" and "char" not in self.type:
self.member_type = "Member<%s>" % self.type[:-1]
@@ -168,8 +166,7 @@ class Parameter(object):
def build_param_name(param_type):
- base_name = re.match(r"(const |PassRefPtr<)?(\w*)", param_type).group(2)
- return "param" + base_name
+ return "param" + re.match(r"(const |RefPtr<)?(\w*)", param_type).group(2)
def load_config(file_name):
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698