[recipes.py] move run arg parsing to its module.

[recipes.py] move run arg parsing to its module.

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2846703003
Committed: https://github.com/luci/recipes-py/commit/19f9db6216068ce8f6af43e95f80bd8954b256bd

[iannucci, 2017-04-27 01:07:40]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 01:07:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 01:10:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 01:10:34]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35c5c5fc227fd710)

[iannucci, 2017-04-27 02:39:27]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 02:39:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 02:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 02:49:01]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35c618d86d0bc810)

[iannucci, 2017-04-27 04:21:55]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 04:22:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 04:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 04:29:36]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35c676ca5f9fce10)

[iannucci, 2017-04-27 04:47:34]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 04:47:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 04:51:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 04:51:28]

Dry run: This issue passed the CQ dry run.

[dnj, 2017-04-27 17:14:02]

lgtm w/ comment

https://codereview.chromium.org/2846703003/diff/60001/recipe_engine/run.py
File recipe_engine/run.py (right):

https://codereview.chromium.org/2846703003/diff/60001/recipe_engine/run.py#ne...
recipe_engine/run.py:69: import argparse
nit: order

https://codereview.chromium.org/2846703003/diff/60001/recipe_engine/run.py#ne...
recipe_engine/run.py:80: from . import env
Shouldn't this be merged above?

https://codereview.chromium.org/2846703003/diff/60001/recipe_engine/run.py#ne...
recipe_engine/run.py:517: 
nit: two spaces (here and elsewhere)

[iannucci, 2017-04-29 15:41:17]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 15:41:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 15:43:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 15:43:54]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-04-29 15:45:38]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 15:45:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-04-29 15:45:59]

https://codereview.chromium.org/2846703003/diff/60001/recipe_engine/run.py
File recipe_engine/run.py (right):

https://codereview.chromium.org/2846703003/diff/60001/recipe_engine/run.py#ne...
recipe_engine/run.py:69: import argparse
On 2017/04/27 17:14:01, dnj wrote:
> nit: order

Done.

https://codereview.chromium.org/2846703003/diff/60001/recipe_engine/run.py#ne...
recipe_engine/run.py:80: from . import env
On 2017/04/27 17:14:01, dnj wrote:
> Shouldn't this be merged above?

I like to keep the env import line separate because it's semi magic.

https://codereview.chromium.org/2846703003/diff/60001/recipe_engine/run.py#ne...
recipe_engine/run.py:517: 
On 2017/04/27 17:14:01, dnj wrote:
> nit: two spaces (here and elsewhere)

Done.

[commit-bot: I haz the power, 2017-04-29 15:48:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 15:48:14]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-04-29 15:57:32]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-04-29 15:57:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/2846703003/#ps80002
(title: "fix nits")

[commit-bot: I haz the power, 2017-04-29 15:57:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 16:00:15]

CQ is committing da patch.

Bot data: {"patchset_id": 80002, "attempt_start_ts": 1493481452669470,
"parent_rev": "db10da8f2f560285dcb5f3d7638fcf69011e2326", "commit_rev":
"19f9db6216068ce8f6af43e95f80bd8954b256bd"}

[commit-bot: I haz the power, 2017-04-29 16:00:18]

Description was changed from

==========
[recipes.py] move run arg parsing to its module.

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=
==========

to

==========
[recipes.py] move run arg parsing to its module.

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2846703003
Committed:
https://github.com/luci/recipes-py/commit/19f9db6216068ce8f6af43e95f80bd8954b...
==========

[commit-bot: I haz the power, 2017-04-29 16:00:20]

Committed patchset #6 (id:80002) as
https://github.com/luci/recipes-py/commit/19f9db6216068ce8f6af43e95f80bd8954b...