Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2846693003: Finch kill switch feature for background tab. (Closed)

Created:
3 years, 7 months ago by mattcary
Modified:
3 years, 7 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Finch kill switch feature for background tab. Adds the CCTBackgroundTab (ChromeFeatureList::CCT_BACKGROUND_TAB) feature which is enabled by default. NOTRY=true NOPRESUBMIT=true TBR=lizeb@chromium.org BUG=708173 Review-Url: https://codereview.chromium.org/2837873002 Cr-Commit-Position: refs/heads/master@{#467281} (cherry picked from commit d9b19c661ed366be0c901cc45257160986bab530) Review-Url: https://codereview.chromium.org/2846693003 Cr-Commit-Position: refs/branch-heads/3071@{#341} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/23ffaed4d4c02a308db305e49fb8d1eab53303dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 2 chunks +22 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Benoit L
On 2017/04/27 12:51:58, mattcary wrote: > Description was changed from > > ========== > Finch ...
3 years, 7 months ago (2017-04-27 15:26:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846693003/1
3 years, 7 months ago (2017-05-02 07:33:00 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 7 months ago (2017-05-02 07:33:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846693003/1
3 years, 7 months ago (2017-05-02 07:35:42 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 07:36:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23ffaed4d4c02a308db305e49fb8...

Powered by Google App Engine
This is Rietveld 408576698