Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2846683003: [heap] Verify that new space objects are in to space after evacuation (Closed)

Created:
3 years, 7 months ago by Michael Lippautz
Modified:
3 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Verify that new space objects are in to space after evacuation BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2846683003 Cr-Commit-Position: refs/heads/master@{#44918} Committed: https://chromium.googlesource.com/v8/v8/+/6cc6672fde53458667b4d2ef212a4157dc76d4c1

Patch Set 1 #

Patch Set 2 : Add missing heap getter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/heap/mark-compact.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Michael Lippautz
ptal, separate patch for full MC in case this flushes something out
3 years, 7 months ago (2017-04-27 06:50:51 UTC) #2
ulan
lgtm
3 years, 7 months ago (2017-04-27 07:02:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846683003/20001
3 years, 7 months ago (2017-04-27 08:59:18 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 09:23:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/6cc6672fde53458667b4d2ef212a4157dc7...

Powered by Google App Engine
This is Rietveld 408576698