Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2846673007: Fix the QUIC_FLAG_COUNT_IMPL to actually log the flag name. (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the QUIC_FLAG_COUNT_IMPL to actually log the flag name. old: FLAG_##flag: 1 new: FLAG_quic_reloadable_flag_quic_flow_control_faster_autotune: 1 Review-Url: https://codereview.chromium.org/2846673007 Cr-Commit-Position: refs/heads/master@{#468138} Committed: https://chromium.googlesource.com/chromium/src/+/d623d073be29d13ce319a1defad5990863191dc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/quic/platform/impl/quic_flag_utils_impl.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Ryan Hamilton
3 years, 7 months ago (2017-04-28 19:45:04 UTC) #2
Zhongyi Shi
lgtm
3 years, 7 months ago (2017-04-28 19:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846673007/1
3 years, 7 months ago (2017-04-28 19:47:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/373147)
3 years, 7 months ago (2017-04-28 20:49:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846673007/1
3 years, 7 months ago (2017-04-28 21:03:10 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 21:37:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d623d073be29d13ce319a1defad5...

Powered by Google App Engine
This is Rietveld 408576698