Omnibox: Make InMemoryURLIndex respect hidden URLRows

components/omnibox/browser/in_memory_url_index_unittest.cc

Index: components/omnibox/browser/in_memory_url_index_unittest.cc
diff --git a/components/omnibox/browser/in_memory_url_index_unittest.cc b/components/omnibox/browser/in_memory_url_index_unittest.cc
index 36320e9f4be919aad4127857153b9921ef33c7bf..c82bbba96cf79d0bbe16185d15ada8b20e94151d 100644
--- a/components/omnibox/browser/in_memory_url_index_unittest.cc
+++ b/components/omnibox/browser/in_memory_url_index_unittest.cc
@@ -482,6 +482,20 @@ TEST_F(LimitedInMemoryURLIndexTest, Initialization) {
   EXPECT_EQ(17U, private_data.word_map_.size());
 }
 
+TEST_F(InMemoryURLIndexTest, HiddenURLRowsAreIgnored) {

[Mark P, 2017/05/03 19:04:49]

Please confirm that this test fails before your fix.  (It's not obvious to me
that you're setting everything that needs to be set to get the URL back in the
first place.)

[tommycli, 2017/05/03 19:24:59]

Done. I can confirm this test fails before the fix, and succeeds after. It sets
the same fields as the HugeResultSet test, so if that test works, so should this
one. :)

+  history::URLID new_row_id = 87654321;  // Arbitrarily chosen large new row id.
+  history::URLRow new_row =
+      history::URLRow(GURL("http://hidden.com"), new_row_id++);

[Mark P, 2017/05/03 19:04:49]

nit: add trailing slash to make proper URL :-)

[tommycli, 2017/05/03 19:24:59]

Done.

+  new_row.set_last_visit(base::Time::Now());
+  new_row.set_hidden(true);
+
+  EXPECT_FALSE(UpdateURL(new_row));
+  EXPECT_EQ(0U, url_index_
+                    ->HistoryItemsForTerms(ASCIIToUTF16("hidden"),
+                                           base::string16::npos, kMaxMatches)
+                    .size());
+}
+
 TEST_F(InMemoryURLIndexTest, Retrieval) {
   // See if a very specific term gives a single result.
   ScoredHistoryMatches matches = url_index_->HistoryItemsForTerms(