Omnibox: Make InMemoryURLIndex respect hidden URLRows

components/history/core/browser/url_database.cc

Index: components/history/core/browser/url_database.cc
diff --git a/components/history/core/browser/url_database.cc b/components/history/core/browser/url_database.cc
index 248ecf47d865bd0944aad9a375fd9fa7f433977e..0c08d4b9d62835e220abcdb9fd65b1aae624ac24 100644
--- a/components/history/core/browser/url_database.cc
+++ b/components/history/core/browser/url_database.cc
@@ -639,6 +639,9 @@ base::Time AutocompleteAgeThreshold() {
 
 bool RowQualifiesAsSignificant(const URLRow& row,

[Mark P, 2017/05/03 19:04:49]

While you're here, can you revise the .h comment for this function by replacing
|time_cache| with |threshold|?
thanks!

[tommycli, 2017/05/03 19:24:59]

Done.

                                const base::Time& threshold) {
+  if (row.hidden())
+    return false;

[tommycli, 2017/05/02 18:09:34]

A side note, this is also used in HistoryURLProvider::DoAutocomplete. However,
it's harmless, since hidden rows are already excluded in the SQL query there.

[Mark P, 2017/05/03 19:04:48]

Acknowledged.

+
   const base::Time& real_threshold =
       threshold.is_null() ? AutocompleteAgeThreshold() : threshold;
   return (row.typed_count() >= kLowQualityMatchTypedLimit) ||