Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849

Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849

This roll includes:
  - [inspector_protocol] added StringUtil::toDouble method as requirement [1]
    
[1] https://codereview.chromium.org/2843223005/

BUG=chromium:712610
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2846673005
Cr-Commit-Position: refs/heads/master@{#44954}
Committed: https://chromium.googlesource.com/v8/v8/+/aed22ad12f66fdf95ea30fe857253f4d055fc8fb

[kozy, 2017-04-27 21:42:48]

Description was changed from

==========
[inspector] StringToDouble should not depend on current locale

We need this conversion for parsing JSON.

BUG=chromium:712610
R=dgozman@chromium.org
==========

to

==========
[inspector] roll inspector_protocol

BUG=chromium:712610
R=dgozman@chromium.org
==========

[kozy, 2017-04-27 21:43:05]

Dmitry, please take a look.

[dgozman, 2017-04-27 23:03:48]

https://codereview.chromium.org/2846673005/diff/1/src/inspector/string-util.cc
File src/inspector/string-util.cc (right):

https://codereview.chromium.org/2846673005/diff/1/src/inspector/string-util.c...
src/inspector/string-util.cc:99: v8::internal::UnicodeCache unicode_cache;
This class looks huuuge.

[kozy, 2017-04-27 23:30:59]

kozyatinskiy@chromium.org changed reviewers:
+ alph@chromium.org

[kozy, 2017-04-27 23:31:00]

Alexey, please take a look!

https://codereview.chromium.org/2846673005/diff/1/src/inspector/string-util.cc
File src/inspector/string-util.cc (right):

https://codereview.chromium.org/2846673005/diff/1/src/inspector/string-util.c...
src/inspector/string-util.cc:99: v8::internal::UnicodeCache unicode_cache;
On 2017/04/27 23:03:48, dgozman wrote:
> This class looks huuuge.

sizeof(UnicodeCache) == 3624 bytes, all member constructors are empty and marked
as inlined - I hope C++ can allocate objects like this on stack by several
instructions. This function couldn't call itself recursively then it means we
have this object maximum once on stack during running our parser.

[kozy, 2017-04-28 00:08:11]

I profiled code, yes it adds 30% for parsing double but this addition is non
observable (less then 1%) when we calling parseJSON with simple object
("{"a":0.5}"). I think we can later make this object static later when this
function becomes to be bottle neck.

[kozy, 2017-04-28 00:08:17]

Patchset #2 (id:20001) has been deleted

[dgozman, 2017-04-28 00:10:13]

lgtm

https://codereview.chromium.org/2846673005/diff/1/test/inspector/debugger/pro...
File test/inspector/debugger/protocol-string-to-double-locale-expected.txt
(right):

https://codereview.chromium.org/2846673005/diff/1/test/inspector/debugger/pro...
test/inspector/debugger/protocol-string-to-double-locale-expected.txt:1: {
This test verifies that ....

[kozy, 2017-04-28 01:00:29]

Description was changed from

==========
[inspector] roll inspector_protocol

BUG=chromium:712610
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849

This roll includes:
  - [inspector_protocol] added StringUtil::toDouble method as requirement [1]
    
[1] https://codereview.chromium.org/2843223005/
BUG=chromium:712610
R=dgozman@chromium.org
==========

[kozy, 2017-04-28 01:00:39]

Description was changed from

==========
Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849

This roll includes:
  - [inspector_protocol] added StringUtil::toDouble method as requirement [1]
    
[1] https://codereview.chromium.org/2843223005/
BUG=chromium:712610
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849

This roll includes:
  - [inspector_protocol] added StringUtil::toDouble method as requirement [1]
    
[1] https://codereview.chromium.org/2843223005/

BUG=chromium:712610
R=dgozman@chromium.org
==========

[kozy, 2017-04-28 01:05:43]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-04-28 01:05:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2846673005/#ps60001
(title: "ac")

[commit-bot: I haz the power, 2017-04-28 01:05:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:43:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493341543088390,
"parent_rev": "8f0c2949c1653638d41e1e9dff6b44df8201c67d", "commit_rev":
"aed22ad12f66fdf95ea30fe857253f4d055fc8fb"}

[commit-bot: I haz the power, 2017-04-28 01:43:10]

Description was changed from

==========
Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849

This roll includes:
  - [inspector_protocol] added StringUtil::toDouble method as requirement [1]
    
[1] https://codereview.chromium.org/2843223005/

BUG=chromium:712610
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849

This roll includes:
  - [inspector_protocol] added StringUtil::toDouble method as requirement [1]
    
[1] https://codereview.chromium.org/2843223005/

BUG=chromium:712610
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2846673005
Cr-Commit-Position: refs/heads/master@{#44954}
Committed:
https://chromium.googlesource.com/v8/v8/+/aed22ad12f66fdf95ea30fe857253f4d055...
==========

[commit-bot: I haz the power, 2017-04-28 01:43:11]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/aed22ad12f66fdf95ea30fe857253f4d055...