MD Bookmarks: Simplify and improve consistency of CSS

MD Bookmarks: Simplify and improve consistency of CSS

- Apply color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance
- Make item highlight colors consistent

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846673003
Cr-Commit-Position: refs/heads/master@{#468296}
Committed: https://chromium.googlesource.com/chromium/src/+/1df8e5abe3d4a6b90c62f113f35ff41974fe64b6

[tsergeant, 2017-04-27 05:40:24]

Description was changed from

==========
MD Bookmarks: Simplify and improve consistency of CSS

- Applies color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance

BUG=715394
==========

to

==========
MD Bookmarks: Simplify and improve consistency of CSS

- Applies color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-04-27 05:40:56]

Description was changed from

==========
MD Bookmarks: Simplify and improve consistency of CSS

- Applies color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Simplify and improve consistency of CSS

- Apply color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-04-27 05:45:35]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 05:45:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 07:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 07:38:44]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-04-27 08:04:56]

Description was changed from

==========
MD Bookmarks: Simplify and improve consistency of CSS

- Apply color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Simplify and improve consistency of CSS

- Apply color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance
- Make item highlight colors consistent

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-04-27 08:05:58]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 08:06:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-04-27 08:09:49]

The CQ bit was unchecked by tsergeant@chromium.org

[tsergeant, 2017-04-27 08:12:36]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2017-04-27 08:12:50]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2017-05-01 03:52:36]

lg

https://codereview.chromium.org/2846673003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/item.html (right):

https://codereview.chromium.org/2846673003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/item.html:45: display: block;
Is this line-height interaction something we want to apply to all iron-icons?

https://codereview.chromium.org/2846673003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/item.html:57: </style>
nit: Unindent tag

[tsergeant, 2017-05-01 04:31:27]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[tsergeant, 2017-05-01 04:31:39]

https://codereview.chromium.org/2846673003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/item.html (right):

https://codereview.chromium.org/2846673003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/item.html:45: display: block;
On 2017/05/01 03:52:35, calamity wrote:
> Is this line-height interaction something we want to apply to all iron-icons?

I don't necessarily think so. It only comes about because of a pretty specific
interaction in the way this is laid out.

I've also changed this to apply `display: flex` to #icon-wrapper instead of
`display: block` to #folder-icon, which fixes the same issue in hopefully a
slightly clearer way.

https://codereview.chromium.org/2846673003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/item.html:57: </style>
On 2017/05/01 03:52:35, calamity wrote:
> nit: Unindent tag

Done.

[commit-bot: I haz the power, 2017-05-01 04:31:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-05-01 04:43:12]

lgtm

[commit-bot: I haz the power, 2017-05-01 05:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 05:14:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-05-01 05:28:54]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-05-01 05:28:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2846673003/#ps80001
(title: "Restore icon ID. We need it in tests")

[commit-bot: I haz the power, 2017-05-01 05:29:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 06:32:15]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493616534774810,
"parent_rev": "9c5604209f8fc4438c7e141696089c3d2985928b", "commit_rev":
"1df8e5abe3d4a6b90c62f113f35ff41974fe64b6"}

[commit-bot: I haz the power, 2017-05-01 06:33:36]

Description was changed from

==========
MD Bookmarks: Simplify and improve consistency of CSS

- Apply color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance
- Make item highlight colors consistent

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Simplify and improve consistency of CSS

- Apply color and line-height to the whole page
- Set iron-icon-width/height globally, reducing the number of places
  where specific sizing is necessary
- Import cr-shared-style into Bookmarks' shared style module, which
  removes the need to specify some button styles
- Use paper-icon-button-light in folder-node, which simplifies CSS and
  slightly improves performance
- Make item highlight colors consistent

BUG=715394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846673003
Cr-Commit-Position: refs/heads/master@{#468296}
Committed:
https://chromium.googlesource.com/chromium/src/+/1df8e5abe3d4a6b90c62f113f35f...
==========

[commit-bot: I haz the power, 2017-05-01 06:33:37]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1df8e5abe3d4a6b90c62f113f35f...