Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2846613002: Fix a CHECK when monitor configuration changes (Closed)

Created:
3 years, 7 months ago by stanisc
Modified:
3 years, 7 months ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a CHECK when monitor configuration changes This fix is specific to GPU V-sync configuration (e.g. running Chrome with --enable-features=D3DVsync switch). When monitor configuration changes GetMonitorInfo returns FALSE and the output data remains uninitialized. In this case GpuVSyncProvider will use a backup delay based v-sync mechanism. It looks a similar problem might exist in a general case as well. I am going to address it separately. BUG=467617 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2846613002 Cr-Commit-Position: refs/heads/master@{#467504} Committed: https://chromium.googlesource.com/chromium/src/+/d476ca3a02a6c06d45ef3d83573fa094ca4f52d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M gpu/ipc/service/gpu_vsync_provider_win.cc View 4 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
stanisc
PTAL!
3 years, 7 months ago (2017-04-26 22:10:30 UTC) #6
jbauman
lgtm
3 years, 7 months ago (2017-04-26 22:24:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846613002/1
3 years, 7 months ago (2017-04-26 23:12:01 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 23:22:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d476ca3a02a6c06d45ef3d83573f...

Powered by Google App Engine
This is Rietveld 408576698