Support checking and fixing non-existing header files in GN

Support checking and fixing non-existing header files in GN

BUG=716359
Review-Url: https://codereview.chromium.org/2846593007
Cr-Commit-Position: refs/heads/master@{#468230}
Committed: https://chromium.googlesource.com/chromium/src/+/e7a3d6480969e0a0ef64fa44f7bcae57f312b04e

[wychen, 2017-04-28 07:51:57]

Description was changed from

==========
Check and fix extra header files in GN

BUG=661774
==========

to

==========
Support checking and fixing extra header files in GN

BUG=661774
==========

[wychen, 2017-04-28 08:04:38]

Description was changed from

==========
Support checking and fixing extra header files in GN

BUG=661774
==========

to

==========
Support checking and fixing extra header files in GN

BUG=716359
==========

[wychen, 2017-04-28 08:04:38]

wychen@chromium.org changed reviewers:
+ thakis@chromium.org

[wychen, 2017-04-28 08:35:00]

PTAL

[Nico, 2017-04-28 20:31:19]

"extra" is a confusing word for me in this context. Maybe "non-existing"
instead?

lgtm

https://codereview.chromium.org/2846593007/diff/1/build/check_gn_headers.py
File build/check_gn_headers.py (right):

https://codereview.chromium.org/2846593007/diff/1/build/check_gn_headers.py#n...
build/check_gn_headers.py:110: def FilterOutDepsedRepo(files, deps):
a) isn't this slow? i would've thought that deps has many elements, and this is
in O(len(files) * len(deps))

b) why is it needed?

[wychen, 2017-04-28 22:04:25]

Description was changed from

==========
Support checking and fixing extra header files in GN

BUG=716359
==========

to

==========
Support checking and fixing non-existing header files in GN

BUG=716359
==========

[wychen, 2017-04-28 22:04:43]

Renamed extra and updated CL description.

https://codereview.chromium.org/2846593007/diff/1/build/check_gn_headers.py
File build/check_gn_headers.py (right):

https://codereview.chromium.org/2846593007/diff/1/build/check_gn_headers.py#n...
build/check_gn_headers.py:110: def FilterOutDepsedRepo(files, deps):
On 2017/04/28 20:31:19, Nico wrote:
> a) isn't this slow? i would've thought that deps has many elements, and this
is
> in O(len(files) * len(deps))

This is asymptotically slow, but only takes <0.1sec. The bottleneck is at ninja
deps, so I'm not too worried about the speed here.

> b) why is it needed?

Originally this script was intended for CQ and waterfall. The problem of having
missing GN header file is that "gn analyze" step would wrongly skip some
targets. However, for header changes due to DEPS updates, "gn analyze" would
bail to build all, so it's less bad.

The design doc discussion for reference:
https://docs.google.com/a/google.com/document/d/1TZtquZp1uv1ENe2Okk8zyyeJP03h...

We could fix these as well, but the priority should be on headers that could
lead to practical problems.

[wychen, 2017-04-29 07:02:43]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-04-29 07:02:43]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2846593007/#ps40001
(title: "more naming")

[commit-bot: I haz the power, 2017-04-29 07:02:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 07:12:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493449363466900,
"parent_rev": "32fdf2ad9ef36269d8c5369c4ce667a80c50d0d9", "commit_rev":
"e7a3d6480969e0a0ef64fa44f7bcae57f312b04e"}

[commit-bot: I haz the power, 2017-04-29 07:12:33]

Description was changed from

==========
Support checking and fixing non-existing header files in GN

BUG=716359
==========

to

==========
Support checking and fixing non-existing header files in GN

BUG=716359

Review-Url: https://codereview.chromium.org/2846593007
Cr-Commit-Position: refs/heads/master@{#468230}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7a3d6480969e0a0ef64fa44f7bc...
==========

[commit-bot: I haz the power, 2017-04-29 07:12:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e7a3d6480969e0a0ef64fa44f7bc...