Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2846503002: [Remote suggestions] Get favicon URLs from archive (Closed)

Created:
3 years, 8 months ago by jkrcal
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Remote suggestions] Get favicon URLs from archive Fetching favicons via content suggestions service is currently only enabled for remote suggestions. The general API for getting the URL is via content_suggestion.h which does not work for archived suggestions (i.e. by Fetch More). This CL introduces a quick fix to loop in remote suggestions provider for the favicon URLs of suggestions not known to ContentSuggestionsService. A cleaner fix requires more thinking / refactoring. This is a M59 merge candidate. BUG=714025 Review-Url: https://codereview.chromium.org/2829963005 Cr-Commit-Position: refs/heads/master@{#466653} (cherry picked from commit 8083bc5ed7a1989652884bec28bf775dd198b447) Review-Url: https://codereview.chromium.org/2846503002 . Cr-Commit-Position: refs/branch-heads/3071@{#219} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0a1c2e959fc5b622ce4b82239c4afa5a56404d0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -14 lines) Patch
M components/ntp_snippets/content_suggestion.h View 1 chunk +8 lines, -3 lines 0 comments Download
M components/ntp_snippets/content_suggestion.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.cc View 3 chunks +26 lines, -11 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkrcal
3 years, 8 months ago (2017-04-26 07:51:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a1c2e959fc5b622ce4b82239c4afa5a56404d0b.

Powered by Google App Engine
This is Rietveld 408576698