Chromium Code Reviews Chromium Code Reviews
Issue
2846453002:
Revert "Roll src/third_party/skia/ c1889823d..600effbdc (2 commits)" (Closed)
DescriptionRevert "Roll src/third_party/skia/ c1889823d..600effbdc (2 commits)"
This reverts commit a0717ac57c2ce54ecf2ee0ed86a428a5d1566a77.
Reason for revert: Hits Skia assertion failures for two tests:
virtual/gpu/fast/canvas/OffscreenCanvas-empty-image-source.html
virtual/gpu/fast/canvas/OffscreenCanvas-zero-size-readback.html
See bug for more details.
Original change's description:
> Roll src/third_party/skia/ c1889823d..600effbdc (2 commits)
>
> https://skia.googlesource.com/skia.git/+log/c1889823de68..600effbdc7d8
>
> $ git log c1889823d..600effbdc --date=short --no-merges --format='%ad %ae %s'
> 2017-04-24 scroggo Improve the Codec_end test and add fixes
> 2017-04-24 robertphillips Rm makeRenderTargetContext in favor of deferred version (take 3)
>
> Created with:
> roll-dep src/third_party/skia
>
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
>
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> TBR=benjaminwagner@chromium.org
>
> Change-Id: Icb5c66a3b1c30f99d72fce298a0f8c51394cae8b
> Reviewed-on: https://chromium-review.googlesource.com/486271
> Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>;
> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>;
> Cr-Commit-Position: refs/heads/master@{#466989}
TBR=skia-deps-roller@chromium.org,benjaminwagner@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
BUG=715392
Review-Url: https://codereview.chromium.org/2846453002
Cr-Commit-Position: refs/heads/master@{#467227}
Committed: https://chromium.googlesource.com/chromium/src/+/2330a79389bf0976eea62788b434a366b0e72c5b
Patch Set 1 #Messages
Total messages: 7 (4 generated)
|
