Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2846443002: Call WC::GetContainerBounds() once in ExtensionTabUtil::CreateTabObject. (Closed)

Created:
3 years, 8 months ago by lazyboy
Modified:
3 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Call WC::GetContainerBounds() once in ExtensionTabUtil::CreateTabObject. GetContainerBounds isn't a simple getter, avoid calling it more than necessary. Also, update setting unique_ptr-s to use MakeUnique instead of reset(). BUG=None Test=None Review-Url: https://codereview.chromium.org/2846443002 Cr-Commit-Position: refs/heads/master@{#467509} Committed: https://chromium.googlesource.com/chromium/src/+/8b1df3024af0fd5cef9600e07771a3bf3afc8ff2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +20 lines, -17 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
lazyboy
3 years, 8 months ago (2017-04-26 20:16:37 UTC) #7
Devlin
lgtm, thanks for the cleanup!
3 years, 7 months ago (2017-04-26 23:02:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846443002/1
3 years, 7 months ago (2017-04-26 23:30:33 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 23:38:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b1df3024af0fd5cef9600e07771...

Powered by Google App Engine
This is Rietveld 408576698