Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: third_party/WebKit/Source/core/dom/ClassicPendingScript.h

Issue 2846363003: Introduce ClassicPendingScript::is_external_ explicitly (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ClassicPendingScript.h
diff --git a/third_party/WebKit/Source/core/dom/ClassicPendingScript.h b/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
index aa78d17141ae8353edc8616ccb0b6ea86f2bfb4f..7110a9083ceb455ed12fc3a3007f47e596f84c08 100644
--- a/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
+++ b/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
@@ -49,7 +49,7 @@ class CORE_EXPORT ClassicPendingScript final
ClassicScript* GetSource(const KURL& document_url,
bool& error_occurred) const override;
bool IsReady() const override;
- bool IsExternal() const override { return GetResource(); }
+ bool IsExternal() const override { return is_external_; }
bool ErrorOccurred() const override;
bool WasCanceled() const override;
void StartStreamingIfPossible(Document*, ScriptStreamer::Type) override;
@@ -75,6 +75,8 @@ class CORE_EXPORT ClassicPendingScript final
// MemoryCoordinatorClient
void OnPurgeMemory() override;
+ const bool is_external_;
+
bool integrity_failure_;
Member<ScriptStreamer> streamer_;

Powered by Google App Engine
This is Rietveld 408576698