Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2846363002: Clipboard Android - Store and Read Last Modified Time from Prefs (Closed)

Created:
3 years, 7 months ago by Mark P
Modified:
3 years, 7 months ago
Reviewers:
Bernhard Bauer, dcheng
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Clipboard Android - Store and Read Last Modified Time from Prefs Tested by enabling clipboard provider and the clipboard interactively on a device. Clipboard suggestions are persisted to and restored from prefs, which works even if I kill Chrome. I also added LOG(INFO) lines during this and saw the writes and reads happening at the correct time and with the right values. BUG=711574 R=bauerb@chromium.org, dcheng@chromium.org Review-Url: https://codereview.chromium.org/2832263002 . Cr-Commit-Position: refs/heads/master@{#467796} (cherry picked from commit ee17df91c787b9da94a89bf7d19704eeb6d130c6) Review-Url: https://codereview.chromium.org/2846363002 . Cr-Commit-Position: refs/branch-heads/3071@{#306} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/72742cd0dd7ae91e429e97288eb7b877604a206f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -4 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/preferences/browser_prefs_android.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/preferences/browser_prefs_android.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A chrome/browser/android/preferences/clipboard_android.h View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/android/preferences/clipboard_android.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_android.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_android.cc View 12 chunks +41 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mark P
3 years, 7 months ago (2017-04-28 22:40:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72742cd0dd7ae91e429e97288eb7b877604a206f.

Powered by Google App Engine
This is Rietveld 408576698