Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2846343002:
DXVA: Avoid infinite recursion (Closed)
DescriptionDXVA: Avoid infinite recursion
I'm guessing this shouldn't happen, but apparently it did anyways.
Let's have a max number of retries...
BUG=715707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2846343002
Cr-Commit-Position: refs/heads/master@{#468561}
Committed: https://chromium.googlesource.com/chromium/src/+/5901bd8cf7dc0a23b5952337a3793f605564d8b9
Patch Set 1 #
Total comments: 4
Patch Set 2 : comments addressed #Messages
Total messages: 19 (14 generated)
Description was changed from ========== DXVA: Avoid infinite recursion I'm guessing this shouldn't happen, but apparently it did anyways. Let's have a max number of retries... BUG=715707 ========== to ========== DXVA: Avoid infinite recursion I'm guessing this shouldn't happen, but apparently it did anyways. Let's have a max number of retries... BUG=715707 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hubbe@chromium.org changed reviewers: + jbauman@chromium.org
lgtm with a couple of nits. https://codereview.chromium.org/2846343002/diff/1/media/gpu/dxva_video_decode... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2846343002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:1784: MFT_OUTPUT_DATA_BUFFER output_data_buffer = {0}; output_sample.Reset(); here in case the previous iteration output a sample for some reason. https://codereview.chromium.org/2846343002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:1816: DVLOG(1) << "Received too many format changes from decoder."; Use RETURN_AND_NOTIFY_ON_FAILURE here so we can detect this in release builds.
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2846343002/diff/1/media/gpu/dxva_video_decode... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2846343002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:1784: MFT_OUTPUT_DATA_BUFFER output_data_buffer = {0}; On 2017/04/29 00:03:44, jbauman wrote: > output_sample.Reset(); here in case the previous iteration output a sample for > some reason. Done. https://codereview.chromium.org/2846343002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:1816: DVLOG(1) << "Received too many format changes from decoder."; On 2017/04/29 00:03:44, jbauman wrote: > Use RETURN_AND_NOTIFY_ON_FAILURE here so we can detect this in release builds. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org Link to the patchset: https://codereview.chromium.org/2846343002/#ps20001 (title: "comments addressed")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493700267423880,
"parent_rev": "1d2fd608a4f16afad4bfc2f1c856c520da1d2d79", "commit_rev":
"5901bd8cf7dc0a23b5952337a3793f605564d8b9"}
Message was sent while issue was closed.
Description was changed from ========== DXVA: Avoid infinite recursion I'm guessing this shouldn't happen, but apparently it did anyways. Let's have a max number of retries... BUG=715707 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== DXVA: Avoid infinite recursion I'm guessing this shouldn't happen, but apparently it did anyways. Let's have a max number of retries... BUG=715707 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2846343002 Cr-Commit-Position: refs/heads/master@{#468561} Committed: https://chromium.googlesource.com/chromium/src/+/5901bd8cf7dc0a23b5952337a379... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5901bd8cf7dc0a23b5952337a379... |
