Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2846333003: Chrome cleaner: move Chrome Cleaner files to their own directory (Closed)

Created:
3 years, 7 months ago by alito
Modified:
3 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vakh+watch_chromium.org, alito+watch_chromium.org, timvolodine, grt+watch_chromium.org, csharp+watch_chromium.org, joenotcharles+watch_chromium.org, chromium-apps-reviews_chromium.org, ftirelo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves Chrome Cleaner-related files to their own subdirectory. Review-Url: https://codereview.chromium.org/2846333003 Cr-Commit-Position: refs/heads/master@{#468459} Committed: https://chromium.googlesource.com/chromium/src/+/f6fcb3575cb5f4af723b92647e4746be3e024604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3052 lines) Patch
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/safe_browsing/chrome_cleaner/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_fetcher_browsertest_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_fetcher_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_fetcher_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_global_error_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/srt_global_error_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/safe_browsing/srt_chrome_prompt_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/safe_browsing/srt_chrome_prompt_impl.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/safe_browsing/srt_client_info_win.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/safe_browsing/srt_client_info_win.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc View 1 chunk +0 lines, -969 lines 0 comments Download
D chrome/browser/safe_browsing/srt_fetcher_win.h View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/browser/safe_browsing/srt_fetcher_win.cc View 1 chunk +0 lines, -1254 lines 0 comments Download
D chrome/browser/safe_browsing/srt_field_trial_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/safe_browsing/srt_field_trial_win.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/safe_browsing/srt_global_error_win.h View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/safe_browsing/srt_global_error_win.cc View 1 chunk +0 lines, -273 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
alito
This moves all srt_* files to safe_browsing/chrome_cleaner. PTAL.
3 years, 7 months ago (2017-04-29 00:41:51 UTC) #5
robertshield
lgtm
3 years, 7 months ago (2017-04-29 23:43:51 UTC) #8
alito
Adding mattm for OWNERS.
3 years, 7 months ago (2017-05-01 01:13:17 UTC) #10
Nathan Parker
new safe_browsing dir LGTM
3 years, 7 months ago (2017-05-01 16:58:44 UTC) #12
alito
Adding for OWNERS approval: afakhry@ for chrome/browser/extensions/api/feedback_private/feedback_private_api.cc waffles@ for chrome/browser/component_updater/*
3 years, 7 months ago (2017-05-01 18:19:39 UTC) #14
waffles
component_updater lgtm
3 years, 7 months ago (2017-05-01 18:21:52 UTC) #15
afakhry
feedback_private lgtm.
3 years, 7 months ago (2017-05-01 20:58:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846333003/1
3 years, 7 months ago (2017-05-01 21:04:21 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:34:55 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6fcb3575cb5f4af723b92647e47...

Powered by Google App Engine
This is Rietveld 408576698