Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2846313002: [blink] Perspective layer should be considered fixed-pos container layer (Closed)

Created:
3 years, 7 months ago by trchen
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[blink] Perspective layer should be considered fixed-pos container layer This CL fixes a bug that fixed-position descendants skip its containing block's perspective transform. Perspective layer (CompositedLayerMapping:: child_transform_layer_) should be considered fixed-pos container if present. BUG=714001 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2833233002 Cr-Commit-Position: refs/heads/master@{#467175} (cherry picked from commit 25eaaeb522126f998e9bd83056f96a5ce3cc78c2) Review-Url: https://codereview.chromium.org/2846313002 . Cr-Commit-Position: refs/branch-heads/3071@{#299} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/425fee0e59a4cbaa0ff67a9f2702a269bcd1ac18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
A third_party/WebKit/LayoutTests/transforms/perspective-fixed-pos-descendant.html View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/transforms/perspective-fixed-pos-descendant-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +31 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
trchen
3 years, 7 months ago (2017-04-28 18:50:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
425fee0e59a4cbaa0ff67a9f2702a269bcd1ac18.

Powered by Google App Engine
This is Rietveld 408576698