Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 2846243002: Wire up rtc_packet_ids to P2PSocketHostTcp, which is required for correct BWE in WebRTC. (Closed)

Created:
3 years, 7 months ago by Stefan
Modified:
3 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Wire up rtc_packet_ids to P2PSocketHostTcp, which is required for correct BWE in WebRTC. BUG=chromium:715099 Review-Url: https://codereview.chromium.org/2841803003 Cr-Commit-Position: refs/heads/master@{#467349} (cherry picked from commit dabbe072b786618bbc557381a0c535596c698822) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2846243002 Cr-Commit-Position: refs/branch-heads/3071@{#297} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/a12e597b35058cd9028f2a339442bab3c5668194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -33 lines) Patch
M content/browser/renderer_host/p2p/socket_host_tcp.h View 2 chunks +13 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 5 chunks +44 lines, -30 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_test_utils.h View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Stefan
Sergey, could you approve this merge and CQ this? I'm not a committer so I ...
3 years, 7 months ago (2017-04-28 14:07:31 UTC) #2
Sergey Ulanov
lgtm
3 years, 7 months ago (2017-04-28 17:40:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846243002/1
3 years, 7 months ago (2017-04-28 17:41:38 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 7 months ago (2017-04-28 17:41:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846243002/1
3 years, 7 months ago (2017-04-28 17:45:37 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 17:46:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a12e597b35058cd9028f2a339442...

Powered by Google App Engine
This is Rietveld 408576698