chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java - Issue 2846233003: 📰 Record user actions on the NTP and Home sheet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

Issue 2846233003: 📰 Record user actions on the NTP and Home sheet (Closed)

Patch Set: Address bauerb@'s comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java » ('j') | tools/metrics/actions/actions.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

index 5b48f40ca669869fec4968c2da9eb0e7c3570726..781c1cf55f2b90d7563ba51142df042482f478bb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

@@ -18,6 +18,7 @@

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.EmptyTabModelSelectorObserver;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

+import org.chromium.chrome.browser.util.FeatureUtilities;

import org.chromium.chrome.browser.util.UrlUtilities;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.ui.base.PageTransition;

@@ -363,7 +364,7 @@ public void onUpdateUrl(Tab tab, String url) {

assert !NewTabPage.isNTPUrl(url);

return;

}

- if (NewTabPage.isNTPUrl(url)) {

+ if (NewTabPage.isNTPUrl(url) && !FeatureUtilities.isChromeHomeEnabled()) {

RecordUserAction.record("MobileNTP.Snippets.VisitEndBackInNTP");

}

endRecording(tab);