Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2846233003: 📰 Record user actions on the NTP and Home sheet (Closed)
Patch Set: Address bauerb@'s comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 7909168d0244263d7383aea662b811c8d2a61a5d..4396fb2e94ad97f2e324db2cb4f05603bc2ccf59 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -41,6 +41,7 @@
import org.chromium.chrome.browser.search_engines.TemplateUrlService.TemplateUrlServiceObserver;
import org.chromium.chrome.browser.suggestions.SuggestionsEventReporter;
import org.chromium.chrome.browser.suggestions.SuggestionsEventReporterBridge;
+import org.chromium.chrome.browser.suggestions.SuggestionsMetrics;
import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegate;
import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegateImpl;
import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegateImpl;
@@ -343,7 +344,7 @@ public void onShown(Tab tab) {
@Override
public void onHidden(Tab tab) {
- if (mIsLoaded) recordNTPInteractionTime();
+ if (mIsLoaded) recordNTPHidden();
}
@Override
@@ -496,11 +497,14 @@ public void setFakeboxDelegate(FakeboxDelegate fakeboxDelegate) {
private void recordNTPShown() {
mLastShownTimeNs = System.nanoTime();
RecordUserAction.record("MobileNTPShown");
+ SuggestionsMetrics.recordSurfaceVisible();
}
- private void recordNTPInteractionTime() {
+ /** Records UMA for the NTP being hidden and the time spent on it. */
+ private void recordNTPHidden() {
RecordHistogram.recordMediumTimesHistogram(
"NewTabPage.TimeSpent", System.nanoTime() - mLastShownTimeNs, TimeUnit.NANOSECONDS);
+ SuggestionsMetrics.recordSurfaceHidden();
}
/**
@@ -548,7 +552,7 @@ public void destroy() {
assert !mIsDestroyed;
assert !ViewCompat
.isAttachedToWindow(getView()) : "Destroy called before removed from window";
- if (mIsLoaded && !mTab.isHidden()) recordNTPInteractionTime();
+ if (mIsLoaded && !mTab.isHidden()) recordNTPHidden();
if (mSnippetsBridge != null) {
mSnippetsBridge.onDestroy();

Powered by Google App Engine
This is Rietveld 408576698