📰 Record user actions on the NTP and Home sheet

components/ntp_tiles/most_visited_sites.cc

Index: components/ntp_tiles/most_visited_sites.cc
diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc
index 6809aa4dcbd236a2b3f1df557907b409b03c50b9..b09aa4c8769532cf033409c06ed4c0a1c0568ddd 100644
--- a/components/ntp_tiles/most_visited_sites.cc
+++ b/components/ntp_tiles/most_visited_sites.cc
@@ -12,6 +12,7 @@
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/feature_list.h"
+#include "base/metrics/user_metrics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/history/core/browser/top_sites.h"
 #include "components/ntp_tiles/constants.h"
@@ -134,6 +135,13 @@ void MostVisitedSites::Refresh() {
 
 void MostVisitedSites::AddOrRemoveBlacklistedUrl(const GURL& url,
                                                  bool add_url) {
+  if (add_url) {

[Marc Treib, 2017/05/05 16:05:39]

nit: Maybe it's time to combine the now-three "if (add_url)"s?

[dgn, 2017/05/08 12:40:50]

Do you mind if I do that in a separate patch? I can split that in
AddBlacklistedUrl and RemoveBlacklistedUrl, but I'd have to propagate it to java
and the other place it's used to not look clunky

[Marc Treib, 2017/05/08 12:46:20]

I just meant to reorder things within this method:

if (add_url) {
  RecordAction(..)
  if (top_sites_) AddBlacklistedUrl(..);
  if (mv_source_ == TileSource::SUGGESTIONS_SERVICE) ...
} else ...

But anyway, it's optional.

[dgn, 2017/05/08 13:40:35]

yeah but because of the style guide you have to add line returns and braces...
then it gets ugly with nested ifs and 2 separate methods look better (IMO) but
I'm trying to keep this CL focused and not touch unrelated lines. I'll do the
change in another CL and if it's preferred I will just do the small change you
recommend anyway.

+    base::RecordAction(base::UserMetricsAction("Suggestions.Site.Removed"));
+  } else {
+    base::RecordAction(
+        base::UserMetricsAction("Suggestions.Site.RemovalUndone"));
+  }
+
   if (top_sites_) {
     // Always blacklist in the local TopSites.
     if (add_url)