📰 Record user actions on the NTP and Home sheet

components/ntp_tiles/most_visited_sites.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_tiles/most_visited_sites.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/feature_list.h"
+#include "base/metrics/user_metrics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/history/core/browser/top_sites.h"
 #include "components/ntp_tiles/constants.h"
 #include "components/ntp_tiles/field_trial.h"
 #include "components/ntp_tiles/icon_cacher.h"
 #include "components/ntp_tiles/pref_names.h"
 #include "components/ntp_tiles/switches.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
 
@@ skipping 102 matching lines @@
   // Also start a request for fresh suggestions.
   Refresh();
 }
 
 void MostVisitedSites::Refresh() {
   suggestions_service_->FetchSuggestionsData();
 }
 
 void MostVisitedSites::AddOrRemoveBlacklistedUrl(const GURL& url,
                                                  bool add_url) {
+  if (add_url) {

[Marc Treib, 2017/05/05 16:05:39]

nit: Maybe it's time to combine the now-three "if (add_url)"s?

[dgn, 2017/05/08 12:40:50]

Do you mind if I do that in a separate patch? I can split that in
AddBlacklistedUrl and RemoveBlacklistedUrl, but I'd have to propagate it to java
and the other place it's used to not look clunky

[Marc Treib, 2017/05/08 12:46:20]

I just meant to reorder things within this method:

if (add_url) {
  RecordAction(..)
  if (top_sites_) AddBlacklistedUrl(..);
  if (mv_source_ == TileSource::SUGGESTIONS_SERVICE) ...
} else ...

But anyway, it's optional.

[dgn, 2017/05/08 13:40:35]

yeah but because of the style guide you have to add line returns and braces...
then it gets ugly with nested ifs and 2 separate methods look better (IMO) but
I'm trying to keep this CL focused and not touch unrelated lines. I'll do the
change in another CL and if it's preferred I will just do the small change you
recommend anyway.

+    base::RecordAction(base::UserMetricsAction("Suggestions.Site.Removed"));
+  } else {
+    base::RecordAction(
+        base::UserMetricsAction("Suggestions.Site.RemovalUndone"));
+  }
+
   if (top_sites_) {
     // Always blacklist in the local TopSites.
     if (add_url)
       top_sites_->AddBlacklistedURL(url);
     else
       top_sites_->RemoveBlacklistedURL(url);
   }
 
   // Only blacklist in the server-side suggestions service if it's active.
   if (mv_source_ == TileSource::SUGGESTIONS_SERVICE) {
@@ skipping 287 matching lines @@
 
 void MostVisitedSites::TopSitesChanged(TopSites* top_sites,
                                        ChangeReason change_reason) {
   if (mv_source_ == TileSource::TOP_SITES) {
     // The displayed tiles are invalidated.
     InitiateTopSitesQuery();
   }
 }
 
 }  // namespace ntp_tiles