Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2279)

Unified Diff: ios/chrome/browser/tabs/BUILD.gn

Issue 2846233002: [ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/BUILD.gn
diff --git a/ios/chrome/browser/tabs/BUILD.gn b/ios/chrome/browser/tabs/BUILD.gn
index 0555e7531e963b746f734c73b564401d049c6ea9..4e28b1c6c93f80923488d82e5d2f25247e6d6ecd 100644
--- a/ios/chrome/browser/tabs/BUILD.gn
+++ b/ios/chrome/browser/tabs/BUILD.gn
@@ -33,8 +33,6 @@ source_set("tabs") {
source_set("tabs_internal") {
sources = [
- "tab.h",
- "tab.mm",
"tab_model.mm",
"tab_model_synced_window_delegate.mm",
"tab_model_synced_window_delegate_getter.mm",
@@ -124,6 +122,8 @@ source_set("tabs_internal") {
source_set("tabs_internal_arc") {
sources = [
"legacy_tab_helper.mm",
+ "tab.h",
+ "tab.mm",
"tab_helper_util.mm",
"tab_model_closing_web_state_observer.h",
"tab_model_closing_web_state_observer.mm",
@@ -142,35 +142,82 @@ source_set("tabs_internal_arc") {
deps = [
":tabs",
"//base",
+ "//components/content_settings/core/browser",
+ "//components/favicon/core",
"//components/favicon/ios",
+ "//components/google/core/browser",
"//components/history/core/browser",
"//components/history/ios/browser",
+ "//components/infobars/core",
"//components/keyed_service/core",
+ "//components/metrics_services_manager",
+ "//components/navigation_metrics",
+ "//components/prefs",
+ "//components/reading_list/core",
+ "//components/search_engines",
"//components/sessions",
+ "//components/signin/core/browser",
"//components/signin/ios/browser",
+ "//components/strings",
+ "//components/url_formatter",
+ "//ios/chrome/app/strings",
"//ios/chrome/browser",
+ "//ios/chrome/browser/autofill",
+ "//ios/chrome/browser/autofill:autofill_internal",
"//ios/chrome/browser/bookmarks",
"//ios/chrome/browser/browser_state",
+ "//ios/chrome/browser/content_settings",
"//ios/chrome/browser/favicon",
"//ios/chrome/browser/find_in_page",
- "//ios/chrome/browser/find_in_page",
+ "//ios/chrome/browser/geolocation:geolocation_internal",
"//ios/chrome/browser/history",
"//ios/chrome/browser/infobars",
+ "//ios/chrome/browser/metrics",
+ "//ios/chrome/browser/metrics:metrics_internal",
+ "//ios/chrome/browser/native_app_launcher:native_app_launcher_internal",
+ "//ios/chrome/browser/passwords",
+ "//ios/chrome/browser/passwords:passwords_internal",
"//ios/chrome/browser/reading_list",
+ "//ios/chrome/browser/search_engines",
"//ios/chrome/browser/sessions",
+ "//ios/chrome/browser/sessions:serialisation",
"//ios/chrome/browser/signin",
+ "//ios/chrome/browser/signin:signin_internal",
+ "//ios/chrome/browser/snapshots",
+ "//ios/chrome/browser/snapshots:snapshots_internal",
"//ios/chrome/browser/ssl",
"//ios/chrome/browser/store_kit",
"//ios/chrome/browser/sync",
"//ios/chrome/browser/translate",
+ "//ios/chrome/browser/u2f",
+ "//ios/chrome/browser/ui",
+ "//ios/chrome/browser/ui:ui_internal",
+ "//ios/chrome/browser/ui/alert_coordinator",
+ "//ios/chrome/browser/ui/commands",
+ "//ios/chrome/browser/ui/downloads",
+ "//ios/chrome/browser/ui/overscroll_actions",
+ "//ios/chrome/browser/ui/reader_mode",
+ "//ios/chrome/browser/ui/sad_tab",
+ "//ios/chrome/browser/ui/toolbar",
+ "//ios/chrome/browser/ui/util",
"//ios/chrome/browser/web",
+ "//ios/chrome/browser/web:sad_tab_tab_helper_delegate",
"//ios/chrome/browser/web:web_internal",
"//ios/chrome/browser/web_state_list",
+ "//ios/net",
"//ios/public/provider/chrome/browser",
+ "//ios/public/provider/chrome/browser/native_app_launcher",
"//ios/web",
+ "//ios/web:user_agent",
+ "//net",
+ "//ui/base",
"//url",
]
- libs = [ "Foundation.framework" ]
+ libs = [
+ "CoreLocation.framework",
+ "Foundation.framework",
+ "UIKit.framework",
+ ]
configs += [ "//build/config/compiler:enable_arc" ]
}
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698