Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: ios/chrome/browser/tabs/BUILD.gn

Issue 2846233002: [ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("tabs") { 5 source_set("tabs") {
6 sources = [ 6 sources = [
7 "legacy_tab_helper.h", 7 "legacy_tab_helper.h",
8 "tab.h", 8 "tab.h",
9 "tab_delegate.h", 9 "tab_delegate.h",
10 "tab_dialog_delegate.h", 10 "tab_dialog_delegate.h",
(...skipping 15 matching lines...) Expand all
26 "//ios/net", 26 "//ios/net",
27 "//ios/web", 27 "//ios/web",
28 "//ios/web:user_agent", 28 "//ios/web:user_agent",
29 "//ui/base", 29 "//ui/base",
30 ] 30 ]
31 libs = [ "UIKit.framework" ] 31 libs = [ "UIKit.framework" ]
32 } 32 }
33 33
34 source_set("tabs_internal") { 34 source_set("tabs_internal") {
35 sources = [ 35 sources = [
36 "tab.h",
37 "tab.mm",
38 "tab_model.mm", 36 "tab_model.mm",
39 "tab_model_synced_window_delegate.mm", 37 "tab_model_synced_window_delegate.mm",
40 "tab_model_synced_window_delegate_getter.mm", 38 "tab_model_synced_window_delegate_getter.mm",
41 ] 39 ]
42 deps = [ 40 deps = [
43 ":tabs", 41 ":tabs",
44 ":tabs_internal_arc", 42 ":tabs_internal_arc",
45 "//base", 43 "//base",
46 "//components/content_settings/core/browser", 44 "//components/content_settings/core/browser",
47 "//components/favicon/core", 45 "//components/favicon/core",
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 allow_circular_includes_from = [ ":tabs_internal_arc" ] 115 allow_circular_includes_from = [ ":tabs_internal_arc" ]
118 libs = [ 116 libs = [
119 "CoreLocation.framework", 117 "CoreLocation.framework",
120 "UIKit.framework", 118 "UIKit.framework",
121 ] 119 ]
122 } 120 }
123 121
124 source_set("tabs_internal_arc") { 122 source_set("tabs_internal_arc") {
125 sources = [ 123 sources = [
126 "legacy_tab_helper.mm", 124 "legacy_tab_helper.mm",
125 "tab.h",
126 "tab.mm",
127 "tab_helper_util.mm", 127 "tab_helper_util.mm",
128 "tab_model_closing_web_state_observer.h", 128 "tab_model_closing_web_state_observer.h",
129 "tab_model_closing_web_state_observer.mm", 129 "tab_model_closing_web_state_observer.mm",
130 "tab_model_list.mm", 130 "tab_model_list.mm",
131 "tab_model_observers.h", 131 "tab_model_observers.h",
132 "tab_model_observers.mm", 132 "tab_model_observers.mm",
133 "tab_model_observers_bridge.h", 133 "tab_model_observers_bridge.h",
134 "tab_model_observers_bridge.mm", 134 "tab_model_observers_bridge.mm",
135 "tab_model_selected_tab_observer.h", 135 "tab_model_selected_tab_observer.h",
136 "tab_model_selected_tab_observer.mm", 136 "tab_model_selected_tab_observer.mm",
137 "tab_model_web_state_list_delegate.h", 137 "tab_model_web_state_list_delegate.h",
138 "tab_model_web_state_list_delegate.mm", 138 "tab_model_web_state_list_delegate.mm",
139 "tab_parenting_observer.h", 139 "tab_parenting_observer.h",
140 "tab_parenting_observer.mm", 140 "tab_parenting_observer.mm",
141 ] 141 ]
142 deps = [ 142 deps = [
143 ":tabs", 143 ":tabs",
144 "//base", 144 "//base",
145 "//components/content_settings/core/browser",
146 "//components/favicon/core",
145 "//components/favicon/ios", 147 "//components/favicon/ios",
148 "//components/google/core/browser",
146 "//components/history/core/browser", 149 "//components/history/core/browser",
147 "//components/history/ios/browser", 150 "//components/history/ios/browser",
151 "//components/infobars/core",
148 "//components/keyed_service/core", 152 "//components/keyed_service/core",
153 "//components/metrics_services_manager",
154 "//components/navigation_metrics",
155 "//components/prefs",
156 "//components/reading_list/core",
157 "//components/search_engines",
149 "//components/sessions", 158 "//components/sessions",
159 "//components/signin/core/browser",
150 "//components/signin/ios/browser", 160 "//components/signin/ios/browser",
161 "//components/strings",
162 "//components/url_formatter",
163 "//ios/chrome/app/strings",
151 "//ios/chrome/browser", 164 "//ios/chrome/browser",
165 "//ios/chrome/browser/autofill",
166 "//ios/chrome/browser/autofill:autofill_internal",
152 "//ios/chrome/browser/bookmarks", 167 "//ios/chrome/browser/bookmarks",
153 "//ios/chrome/browser/browser_state", 168 "//ios/chrome/browser/browser_state",
169 "//ios/chrome/browser/content_settings",
154 "//ios/chrome/browser/favicon", 170 "//ios/chrome/browser/favicon",
155 "//ios/chrome/browser/find_in_page", 171 "//ios/chrome/browser/find_in_page",
156 "//ios/chrome/browser/find_in_page", 172 "//ios/chrome/browser/geolocation:geolocation_internal",
157 "//ios/chrome/browser/history", 173 "//ios/chrome/browser/history",
158 "//ios/chrome/browser/infobars", 174 "//ios/chrome/browser/infobars",
175 "//ios/chrome/browser/metrics",
176 "//ios/chrome/browser/metrics:metrics_internal",
177 "//ios/chrome/browser/native_app_launcher:native_app_launcher_internal",
178 "//ios/chrome/browser/passwords",
179 "//ios/chrome/browser/passwords:passwords_internal",
159 "//ios/chrome/browser/reading_list", 180 "//ios/chrome/browser/reading_list",
181 "//ios/chrome/browser/search_engines",
160 "//ios/chrome/browser/sessions", 182 "//ios/chrome/browser/sessions",
183 "//ios/chrome/browser/sessions:serialisation",
161 "//ios/chrome/browser/signin", 184 "//ios/chrome/browser/signin",
185 "//ios/chrome/browser/signin:signin_internal",
186 "//ios/chrome/browser/snapshots",
187 "//ios/chrome/browser/snapshots:snapshots_internal",
162 "//ios/chrome/browser/ssl", 188 "//ios/chrome/browser/ssl",
163 "//ios/chrome/browser/store_kit", 189 "//ios/chrome/browser/store_kit",
164 "//ios/chrome/browser/sync", 190 "//ios/chrome/browser/sync",
165 "//ios/chrome/browser/translate", 191 "//ios/chrome/browser/translate",
192 "//ios/chrome/browser/u2f",
193 "//ios/chrome/browser/ui",
194 "//ios/chrome/browser/ui:ui_internal",
195 "//ios/chrome/browser/ui/alert_coordinator",
196 "//ios/chrome/browser/ui/commands",
197 "//ios/chrome/browser/ui/downloads",
198 "//ios/chrome/browser/ui/overscroll_actions",
199 "//ios/chrome/browser/ui/reader_mode",
200 "//ios/chrome/browser/ui/sad_tab",
201 "//ios/chrome/browser/ui/toolbar",
202 "//ios/chrome/browser/ui/util",
166 "//ios/chrome/browser/web", 203 "//ios/chrome/browser/web",
204 "//ios/chrome/browser/web:sad_tab_tab_helper_delegate",
167 "//ios/chrome/browser/web:web_internal", 205 "//ios/chrome/browser/web:web_internal",
168 "//ios/chrome/browser/web_state_list", 206 "//ios/chrome/browser/web_state_list",
207 "//ios/net",
169 "//ios/public/provider/chrome/browser", 208 "//ios/public/provider/chrome/browser",
209 "//ios/public/provider/chrome/browser/native_app_launcher",
170 "//ios/web", 210 "//ios/web",
211 "//ios/web:user_agent",
212 "//net",
213 "//ui/base",
171 "//url", 214 "//url",
172 ] 215 ]
173 libs = [ "Foundation.framework" ] 216 libs = [
217 "CoreLocation.framework",
218 "Foundation.framework",
219 "UIKit.framework",
220 ]
174 configs += [ "//build/config/compiler:enable_arc" ] 221 configs += [ "//build/config/compiler:enable_arc" ]
175 } 222 }
176 223
177 source_set("unit_tests") { 224 source_set("unit_tests") {
178 testonly = true 225 testonly = true
179 sources = [ 226 sources = [
180 "tab_model_unittest.mm", 227 "tab_model_unittest.mm",
181 "tab_unittest.mm", 228 "tab_unittest.mm",
182 ] 229 ]
183 deps = [ 230 deps = [
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 ":tabs", 268 ":tabs",
222 ":tabs_internal", 269 ":tabs_internal",
223 "//base", 270 "//base",
224 "//ios/chrome/browser/browser_state:test_support", 271 "//ios/chrome/browser/browser_state:test_support",
225 "//ios/chrome/browser/sessions:test_support", 272 "//ios/chrome/browser/sessions:test_support",
226 "//ios/web:test_support", 273 "//ios/web:test_support",
227 "//testing/gtest", 274 "//testing/gtest",
228 ] 275 ]
229 configs += [ "//build/config/compiler:enable_arc" ] 276 configs += [ "//build/config/compiler:enable_arc" ]
230 } 277 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698