Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2846223002: Fixed some issues with boilerplate.py to make it work on Windows (Closed)

Created:
3 years, 7 months ago by emx
Modified:
3 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed some issues with boilerplate.py to make it work on Windows It now support backslashes in file paths and uses LF as EOL (instead of CRLF) even on Windows. BUG=none Review-Url: https://codereview.chromium.org/2846223002 Cr-Commit-Position: refs/heads/master@{#468063} Committed: https://chromium.googlesource.com/chromium/src/+/359564ee3ab7d63ea062089c12f1a9e6a60e6170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M tools/boilerplate.py View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
emx
Please take a look
3 years, 7 months ago (2017-04-28 12:51:23 UTC) #2
Robert Sesek
lgtm
3 years, 7 months ago (2017-04-28 16:09:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846223002/1
3 years, 7 months ago (2017-04-28 16:27:17 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:17:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/359564ee3ab7d63ea062089c12f1...

Powered by Google App Engine
This is Rietveld 408576698