Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2846213002: Remove ListValue::Append(raw ptr) on Mac and iOS (Closed)

Created:
3 years, 7 months ago by vabr (Chromium)
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(raw ptr) on Mac and iOS ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be used instead. This CL achieves that on Mac and iOS specifically. The CL also changes some related calls to DictionaryValue::Set to take a unique_ptr instead of a raw one. BUG=581865 Review-Url: https://codereview.chromium.org/2817603003 Cr-Commit-Position: refs/heads/master@{#464862} (cherry picked from commit aec0f17718b8e13656d7c9f9fe795a0b8066ffcc) Review-Url: https://codereview.chromium.org/2846213002 . Cr-Commit-Position: refs/branch-heads/3071@{#288} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/ab7a614f33bd8389fa1714e5f0406ac8275c32b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -28 lines) Patch
M base/values.h View 1 chunk +1 line, -1 line 0 comments Download
M base/values.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/mac_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/mac_util_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M components/wifi/fake_wifi_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/wifi/wifi_service_mac.mm View 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 3 chunks +5 lines, -4 lines 0 comments Download
M content/common/font_list_mac.mm View 2 chunks +7 lines, -6 lines 0 comments Download
M ios/chrome/browser/passwords/password_controller.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
3 years, 7 months ago (2017-04-28 08:38:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab7a614f33bd8389fa1714e5f0406ac8275c32b1.

Powered by Google App Engine
This is Rietveld 408576698