Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2846123002: 📰 Consider hidden categories when checking staleness (Closed)

Created:
3 years, 7 months ago by dgn
Modified:
3 years, 7 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Consider hidden categories when checking staleness Some content suggestions categories are hidden when no content is available. The UI used to completely ignore them, when when checking that the list of categories didn't change, that caused the UI's data to be always considered stale. We now keep track of these hidden categories, blacklisting them when they should not be shown, and removing them from the blacklist when we get notified of a change about them. BUG=689962 Review-Url: https://codereview.chromium.org/2846123002 Cr-Commit-Position: refs/heads/master@{#467950} Committed: https://chromium.googlesource.com/chromium/src/+/1ef06828f008ae8d6708e17a0fa35db5ecc48ff5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java View 9 chunks +30 lines, -12 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java View 3 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgn
PTAL
3 years, 7 months ago (2017-04-27 21:54:16 UTC) #4
Michael van Ouwerkerk
lgtm
3 years, 7 months ago (2017-04-28 09:49:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846123002/1
3 years, 7 months ago (2017-04-28 10:18:00 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 10:22:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ef06828f008ae8d6708e17a0fa3...

Powered by Google App Engine
This is Rietveld 408576698