Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm

Issue 2846073002: Use ScopedTaskEnvironment instead of MessageLoopForUI in ios tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm
index 5d32f88ab37b1b0899802843139a169a2828bf9a..3750ffe6976f22ea1ec369a7a4a87f1a4c1365b7 100644
--- a/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm
@@ -9,7 +9,7 @@
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
#include "base/mac/foundation_util.h"
-#include "base/message_loop/message_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/prefs/pref_member.h"
#include "components/prefs/pref_registry_simple.h"
@@ -33,6 +33,10 @@ namespace {
class VoicesearchCollectionViewControllerTest
: public CollectionViewControllerTest {
protected:
+ VoicesearchCollectionViewControllerTest()
+ : scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::UI) {}
+
void SetUp() override {
CollectionViewControllerTest::SetUp();
pref_service_ = CreateLocalState();
@@ -58,7 +62,7 @@ class VoicesearchCollectionViewControllerTest
inSection:0]]);
}
- base::MessageLoopForUI message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
std::unique_ptr<PrefService> pref_service_;
};

Powered by Google App Engine
This is Rietveld 408576698