Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2846053002: [Web Payments] Respect Harmony dialog width in Payment Request (Closed)

Created:
3 years, 7 months ago by anthonyvd
Modified:
3 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Respect Harmony dialog width in Payment Request BUG=716076 Review-Url: https://codereview.chromium.org/2846053002 Cr-Commit-Position: refs/heads/master@{#467757} Committed: https://chromium.googlesource.com/chromium/src/+/a29081ac6e96d3ff5cbd5a69db5c0c06ecafe5c1

Patch Set 1 #

Patch Set 2 : Change the dialog to Large #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/ui/views/payments/payment_request_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
anthonyvd
Hi Math, PTAL!
3 years, 7 months ago (2017-04-27 17:24:39 UTC) #2
Mathieu
lgtm
3 years, 7 months ago (2017-04-27 17:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846053002/20001
3 years, 7 months ago (2017-04-27 17:33:06 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 19:39:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a29081ac6e96d3ff5cbd5a69db5c...

Powered by Google App Engine
This is Rietveld 408576698