Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2846043003:
[heap] Add concept of migration observers to evacuation (Closed)
|
Created:
3 years, 7 months ago by Michael Lippautz Modified:
3 years, 7 months ago CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office) Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Add concept of migration observers to evacuation
Currently used for observing moves for profiling. In the future this
will be used to transfer colors for the minor MC too.
BUG=chromium:651354
Review-Url: https://codereview.chromium.org/2846043003
Cr-Commit-Position: refs/heads/master@{#45021}
Committed: https://chromium.googlesource.com/v8/v8/+/b692e8b112ade0b3d47ef0202b98e7d5269141bd
Patch Set 1 #Patch Set 2 : Offline comments #Patch Set 3 : Typo #Patch Set 4 : Remove unused field #Patch Set 5 : Checking against static functions #Patch Set 6 : Polish static version #Messages
Total messages: 26 (20 generated)
Description was changed from ========== [heap] Add concept of migration observers to evacuation Currently used for observing moves for profiling. In the future this will be used to transfer colors for the minor MC too. BUG= ========== to ========== [heap] Add concept of migration observers to evacuation Currently used for observing moves for profiling. In the future this will be used to transfer colors for the minor MC too. BUG=chromium:651354 ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org, ulan@chromium.org
PTAL Kicked off perf bots to see whether this is performance neutral.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
lgtm modulo offline comments.
lgtm % compile error and perf results
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
For completeness: The static version seems to win wrt. to raw speed. I benchmarked this on Splay with --global-gc and --no-allocation-site-pretenuring. $ cat out-static-2.log | grep gc=ms | ~/workspace/v8/v8/tools/eval_gc_nvp.py evacuate.copy evacuate.copy len: 44 min: 0.1 max: 5.0 avg: 1.89545454545 [0,5[: 43 [5,10[: 1 $ cat out-dynamic-2.log | grep gc=ms | ~/workspace/v8/v8/tools/eval_gc_nvp.py evacuate.copy evacuate.copy len: 46 min: 0.6 max: 4.0 avg: 1.98695652174 [0,5[: 46
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org, hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/2846043003/#ps100001 (title: "Polish static version")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493721893938330,
"parent_rev": "d5401cb225957526607801ff12f904e5e07b14d5", "commit_rev":
"b692e8b112ade0b3d47ef0202b98e7d5269141bd"}
Message was sent while issue was closed.
Description was changed from ========== [heap] Add concept of migration observers to evacuation Currently used for observing moves for profiling. In the future this will be used to transfer colors for the minor MC too. BUG=chromium:651354 ========== to ========== [heap] Add concept of migration observers to evacuation Currently used for observing moves for profiling. In the future this will be used to transfer colors for the minor MC too. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2846043003 Cr-Commit-Position: refs/heads/master@{#45021} Committed: https://chromium.googlesource.com/v8/v8/+/b692e8b112ade0b3d47ef0202b98e7d5269... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/v8/v8/+/b692e8b112ade0b3d47ef0202b98e7d5269... |
