Issue 2846033002: Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE frame every 20 packets which d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2846033002: Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE frame every 20 packets which d… (Closed)

Created:
3 years, 7 months ago by Fan Yang

Modified:
3 years, 7 months ago

Reviewers:
Zhongyi Shi

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE frame every 20 packets which do not have retransmittble frames. Merge internal change: 154290226 R=zhongyi@chromium.org BUG=

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+234 lines, -11 lines)			Patch
M	net/quic/core/quic_connection.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_connection.cc	View	5 chunks	+35 lines, -3 lines	0 comments	Download
M	net/quic/core/quic_connection_test.cc	View	12 chunks	+64 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_flow_controller.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	net/quic/core/quic_flow_controller.cc	View	4 chunks	+9 lines, -5 lines	0 comments	Download
M	net/quic/core/quic_packet_generator.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_packet_generator.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_packet_generator_test.cc	View	35 chunks	+40 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_session.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_session.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_versions.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/test_tools/simple_quic_framer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/test_tools/simple_quic_framer.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/simulator/quic_endpoint.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	1 chunk	+42 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2842373003 Patch 1

Dependent Patchsets:

Issue 2841283003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages