Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2992)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2841283003: Include "base/macros.h" in quic_mutex.h (Closed)

Created:
3 years, 7 months ago by Fan Yang
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Include "base/macros.h" in quic_mutex.h Merge internal change: 154304557 R=zhongyi@chromium.org BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/quic/platform/api/quic_mutex.h View 1 chunk +1 line, -0 lines 1 comment Download

Depends on Patchset:

Issue 2846033002 Patch 1

Dependent Patchsets:

Issue 2848633003 Patch 1

Messages

Total messages: 5 (1 generated)
Fan Yang
3 years, 7 months ago (2017-04-27 14:47:35 UTC) #1
Zhongyi Shi
https://codereview.chromium.org/2841283003/diff/1/net/quic/platform/api/quic_mutex.h File net/quic/platform/api/quic_mutex.h (right): https://codereview.chromium.org/2841283003/diff/1/net/quic/platform/api/quic_mutex.h#newcode8 net/quic/platform/api/quic_mutex.h:8: #include "base/macros.h" Do you need add the #include in ...
3 years, 7 months ago (2017-04-27 19:47:47 UTC) #3
Fan Yang
On 2017/04/27 19:47:47, Zhongyi Shi wrote: > https://codereview.chromium.org/2841283003/diff/1/net/quic/platform/api/quic_mutex.h > File net/quic/platform/api/quic_mutex.h (right): > > https://codereview.chromium.org/2841283003/diff/1/net/quic/platform/api/quic_mutex.h#newcode8 ...
3 years, 7 months ago (2017-04-28 12:40:03 UTC) #4
Zhongyi Shi
3 years, 7 months ago (2017-04-28 18:45:16 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698