Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2846023002: VR: Get fallback fonts for set of characters rather than full string. (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
acondor_, cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Get fallback fonts for set of characters rather than full string. This shaves ~6ms off of our total skia render time for English. Similar numbers for other languages. BUG=715591 Review-Url: https://codereview.chromium.org/2846023002 Cr-Commit-Position: refs/heads/master@{#468070} Committed: https://chromium.googlesource.com/chromium/src/+/255a2914d4d023ca040c250e2ce129e1e5370a05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/android/vr_shell/textures/ui_texture.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mthiesse
PTAL
3 years, 7 months ago (2017-04-27 14:32:08 UTC) #2
acondor_
lgtm
3 years, 7 months ago (2017-04-27 15:24:19 UTC) #3
cjgrant
lgtm
3 years, 7 months ago (2017-04-28 17:31:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846023002/1
3 years, 7 months ago (2017-04-28 17:36:09 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:40:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/255a2914d4d023ca040c250e2ce1...

Powered by Google App Engine
This is Rietveld 408576698