Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2845993002: Convert styleguide to markdown (Closed)

Created:
3 years, 7 months ago by lody
Modified:
3 years, 6 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert styleguide to markdown TBR=marq@chromium.org, eugenebut@chromium.org NOPRESUBMIT=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2845993002 Cr-Commit-Position: refs/heads/master@{#467652} Committed: https://chromium.googlesource.com/chromium/src/+/549b60723e624084a7030bbefc8f870416c780e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M styleguide/objective-c/objective-c.md View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845993002/1
3 years, 7 months ago (2017-04-27 13:06:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/549b60723e624084a7030bbefc8f870416c780e8
3 years, 7 months ago (2017-04-27 13:06:53 UTC) #5
Eugene But (OOO till 7-30)
lgtm
3 years, 7 months ago (2017-04-27 13:20:21 UTC) #6
marq (ping after 24h)
On 2017/04/27 13:20:21, Eugene But wrote: > lgtm Aren't some of these (our TODO format, ...
3 years, 7 months ago (2017-04-27 14:16:10 UTC) #7
marq (ping after 24h)
3 years, 6 months ago (2017-06-21 11:37:57 UTC) #8
Message was sent while issue was closed.
On 2017/04/27 14:16:10, marq (ping after 24h) wrote:
> On 2017/04/27 13:20:21, Eugene But wrote:
> > lgtm
> 
> Aren't some of these (our TODO format, for example) specific only to ios/ and
> not to all Chromium Objective-C?

Yep. This should be reverted and an ios-specific style guide document should be
in ios/.

Powered by Google App Engine
This is Rietveld 408576698