Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO

Issue 2845983002: [modules] Add several new WPT tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO
new file mode 100644
index 0000000000000000000000000000000000000000..f80e062bbabba664800ac43c87ce657a213f010c
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO
@@ -0,0 +1,12 @@
+- In some cases we check that all logged exceptions are the same.
+ Should even the error events be the same?
domenic 2017/04/28 20:12:02 The events should not be; we in fact might want to
+
+- Do we want to assert that the load event is fired only once?
domenic 2017/04/28 20:12:02 That would be ideal, but I'm sure hoping nobody fi
+
+- Some obvious areas where more (or even any) tests are needed:
+ * scriptEl.onerror
+ * scriptEl.onload
+ * defer
+ * Invalid module specifiers.
+ * Fetch errors.
+ * Inline module scripts (once implemented).
domenic 2017/04/28 20:12:02 The ones that stand out for me are scriptEl.onload

Powered by Google App Engine
This is Rietveld 408576698