third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO - Issue 2845983002: [modules] Add several new WPT tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/TODO

Issue 2845983002: [modules] Add several new WPT tests. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 - In some cases we check that all logged exceptions are the same.

	2 Should even the error events be the same?
	domenic 2017/04/28 20:12:02 The events should not be; we in fact might want to The events should not be; we in fact might want to check that they're distinct.
	3

	4 - Do we want to assert that the load event is fired only once?
	domenic 2017/04/28 20:12:02 That would be ideal, but I'm sure hoping nobody fi That would be ideal, but I'm sure hoping nobody fires more than one load event per script, so I'm not sure it's high priority...
	5

	6 - Some obvious areas where more (or even any) tests are needed:

	7 * scriptEl.onerror

	8 * scriptEl.onload

	9 * defer

	10 * Invalid module specifiers.

	11 * Fetch errors.

	12 * Inline module scripts (once implemented).
	domenic 2017/04/28 20:12:02 The ones that stand out for me are scriptEl.onload The ones that stand out for me are scriptEl.onload (should be easy to sprinkle around onload="log.push()"s), invalid module specifiers, and more fetch failure tests (especially around scriptEl.onerror).
OLD	NEW