Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2845973002: Merge two IsInDocument implementations. (Closed)

Created:
3 years, 7 months ago by Daniel Bratell
Modified:
3 years, 7 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge two IsInDocument implementations. There were two helper functions IsInDocument implementations in core/input and this moves them to EventHandlingUtil so they can be shared. R=dtapuska@chromium.org Review-Url: https://codereview.chromium.org/2845973002 Cr-Commit-Position: refs/heads/master@{#467684} Committed: https://chromium.googlesource.com/chromium/src/+/71552a7a961db97918872b48032cf8d98a95cb66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M third_party/WebKit/Source/core/input/BoundaryEventDispatcher.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlingUtil.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlingUtil.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Daniel Bratell
dtapuska, please take a look. I stumbled upon this in the jumbo project which improves ...
3 years, 7 months ago (2017-04-27 09:57:32 UTC) #1
dtapuska
On 2017/04/27 09:57:32, Daniel Bratell wrote: > dtapuska, please take a look. > > I ...
3 years, 7 months ago (2017-04-27 12:52:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845973002/1
3 years, 7 months ago (2017-04-27 13:36:06 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 15:25:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71552a7a961db97918872b48032c...

Powered by Google App Engine
This is Rietveld 408576698