Test OpenType rvrn Required Variation Alternates

Test OpenType rvrn Required Variation Alternates

The rvrn feature [1] and the FeatureVariations part of GSUB describe
single glyph substitutions dependent on variation axis values. In order
to add test coverage for this, the variabletest_box.ttf font was
extended to have two new glyphs for r and R respectively displaying
"rvrn base" and "rvrn subst" (for "substituted"). When a new axis
'fvtt', ranging from 0 to 10, is set to >= 5, the rvrn_base glyph is
replaced with the rvrn_subst glyph. This enables creating a reftest of
where a lowercase r with font-variation-settings: "fvtt" 10; must match
the uppercase R, which selects the "rvrn_subst" glyph explicitly.

[1] https://www.microsoft.com/typography/OTSpec/features_pt.htm#rvrn

BUG=715900
Review-Url: https://codereview.chromium.org/2845953002
Cr-Commit-Position: refs/heads/master@{#467621}
Committed: https://chromium.googlesource.com/chromium/src/+/8ff4d2836039766ef72205144bb5f538d2712116

[drott, 2017-04-27 07:30:16]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 07:30:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-04-27 07:31:14]

drott@chromium.org changed reviewers:
+ behdad@chromium.org, bungeman@chromium.org, eae@chromium.org

[kojii, 2017-04-27 07:43:32]

lgtm, this is great!

[commit-bot: I haz the power, 2017-04-27 08:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 08:33:34]

Dry run: This issue passed the CQ dry run.

[drott, 2017-04-27 08:37:33]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-04-27 08:37:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 08:41:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493282253259140, "parent_rev":
"8db797d21d544547fdf4436072224c01691e938c", "commit_rev":
"8ff4d2836039766ef72205144bb5f538d2712116"}

[commit-bot: I haz the power, 2017-04-27 08:41:55]

Description was changed from

==========
Test OpenType rvrn Required Variation Alternates

The rvrn feature [1] and the FeatureVariations part of GSUB describe
single glyph substitutions dependent on variation axis values. In order
to add test coverage for this, the variabletest_box.ttf font was
extended to have two new glyphs for r and R respectively displaying
"rvrn base" and "rvrn subst" (for "substituted"). When a new axis
'fvtt', ranging from 0 to 10, is set to >= 5, the rvrn_base glyph is
replaced with the rvrn_subst glyph. This enables creating a reftest of
where a lowercase r with font-variation-settings: "fvtt" 10; must match
the uppercase R, which selects the "rvrn_subst" glyph explicitly.

[1] https://www.microsoft.com/typography/OTSpec/features_pt.htm#rvrn

BUG=715900
==========

to

==========
Test OpenType rvrn Required Variation Alternates

The rvrn feature [1] and the FeatureVariations part of GSUB describe
single glyph substitutions dependent on variation axis values. In order
to add test coverage for this, the variabletest_box.ttf font was
extended to have two new glyphs for r and R respectively displaying
"rvrn base" and "rvrn subst" (for "substituted"). When a new axis
'fvtt', ranging from 0 to 10, is set to >= 5, the rvrn_base glyph is
replaced with the rvrn_subst glyph. This enables creating a reftest of
where a lowercase r with font-variation-settings: "fvtt" 10; must match
the uppercase R, which selects the "rvrn_subst" glyph explicitly.

[1] https://www.microsoft.com/typography/OTSpec/features_pt.htm#rvrn

BUG=715900

Review-Url: https://codereview.chromium.org/2845953002
Cr-Commit-Position: refs/heads/master@{#467621}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ff4d2836039766ef72205144bb5...
==========

[commit-bot: I haz the power, 2017-04-27 08:41:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ff4d2836039766ef72205144bb5...

[behdad_google, 2017-04-27 21:35:22]

behdad@google.com changed reviewers:
+ behdad@google.com

[behdad_google, 2017-04-27 21:35:23]

My only comment is that axis tags with lowercase letters are reserved for
standard axes.  Please use uppercase.

[drott, 2017-04-28 08:21:44]

On 2017/04/27 at 21:35:23, behdad wrote:
> My only comment is that axis tags with lowercase letters are reserved for
standard axes.  Please use uppercase.

Thanks, true, I'll update this in a subsequent CL.