Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2845943005:
Avoid importing nacl config for non-NaCl toolchains. (Closed)
DescriptionAvoid importing nacl config for non-NaCl toolchains.
This should help keep the NaCl configuration more separate from the rest of the
build. A comment is added to prevent regressions.
Review-Url: https://codereview.chromium.org/2845943005
Cr-Commit-Position: refs/heads/master@{#468037}
Committed: https://chromium.googlesource.com/chromium/src/+/c4d0415066d9a0f98eb98179f49679906da55c87
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
brettw@chromium.org changed reviewers: + dpranke@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rayb@ca.ibm.com changed reviewers: + rayb@ca.ibm.com
Looks good to me.
Also, I think you need to do the same in '//build/toolchain/gcc_toolchain.gni'. As in guard the '/nacl/config.gni' import. Judging by the description, I think that change should be part of the same cl.
lgtm
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493399156364090, "parent_rev":
"608d9b35feef220d85fb72c679888ff3a3daad8d", "commit_rev":
"c4d0415066d9a0f98eb98179f49679906da55c87"}
Message was sent while issue was closed.
Description was changed from ========== Avoid importing nacl config for non-NaCl toolchains. This should help keep the NaCl configuration more separate from the rest of the build. A comment is added to prevent regressions. ========== to ========== Avoid importing nacl config for non-NaCl toolchains. This should help keep the NaCl configuration more separate from the rest of the build. A comment is added to prevent regressions. Review-Url: https://codereview.chromium.org/2845943005 Cr-Commit-Position: refs/heads/master@{#468037} Committed: https://chromium.googlesource.com/chromium/src/+/c4d0415066d9a0f98eb98179f496... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c4d0415066d9a0f98eb98179f496... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
