Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2845913004: Remove TaskScheduler::CreateAndSetDefaultTaskScheduler(). (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, vmpstr+watch_chromium.org, robliao+watch_chromium.org, jam, gab+watch_chromium.org, darin-cc_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TaskScheduler::CreateAndSetDefaultTaskScheduler(). This method has been replaced by Create() and Start(). R=gab@chromium.org TBR=gab@chromium.org BUG=690706 Review-Url: https://codereview.chromium.org/2845913004 Cr-Commit-Position: refs/heads/master@{#467990} Committed: https://chromium.googlesource.com/chromium/src/+/00b1e7279ad1c6b8b538faa9a5c4facd37dc8666

Patch Set 1 #

Patch Set 2 : fix-build-error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M base/task_scheduler/task_scheduler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M base/task_scheduler/task_scheduler.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M base/test/scoped_async_task_scheduler.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/test/scoped_task_environment.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/service/service_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_process.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
fdoray
3 years, 7 months ago (2017-04-27 17:13:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845913004/1
3 years, 7 months ago (2017-04-27 17:13:58 UTC) #3
robliao
lgtm
3 years, 7 months ago (2017-04-27 17:21:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/62606) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-04-27 17:24:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845913004/20001
3 years, 7 months ago (2017-04-27 20:34:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/285585)
3 years, 7 months ago (2017-04-27 20:51:54 UTC) #14
gab
lgtm
3 years, 7 months ago (2017-04-28 01:51:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845913004/20001
3 years, 7 months ago (2017-04-28 13:13:38 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 14:17:00 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00b1e7279ad1c6b8b538faa9a5c4...

Powered by Google App Engine
This is Rietveld 408576698