Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2845893002: Make EBoxDecorationBreak an enum class. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EBoxDecorationBreak an enum class. This patch makes EBoxDecoration break an enum class for better type safety. BUG=684966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2845893002 Cr-Commit-Position: refs/heads/master@{#467885} Committed: https://chromium.googlesource.com/chromium/src/+/e0bef062337921727eb9b670b417ebd0b6d86fd6

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleBoxData.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 24 (18 generated)
shend
Hi Eddy, PTAL :)
3 years, 8 months ago (2017-04-27 04:22:22 UTC) #5
rune
lgtm
3 years, 8 months ago (2017-04-27 09:57:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845893002/1
3 years, 7 months ago (2017-04-28 01:39:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/422757)
3 years, 7 months ago (2017-04-28 01:50:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845893002/20001
3 years, 7 months ago (2017-04-28 03:57:22 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 04:07:43 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e0bef062337921727eb9b670b417...

Powered by Google App Engine
This is Rietveld 408576698