Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2845883002: [LayoutNG] Add NG-specific DrawText support to GraphicsContext (Closed)

Created:
3 years, 7 months ago by eae
Modified:
3 years, 7 months ago
Reviewers:
kojii
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add NG-specific DrawText support to GraphicsContext Add LayoutNG versions of the DrawText and DrawEmphasisMarks methods that operate on TextFragmentPaintInfo instances (wrapping text fragment data) instead of TextRunPaintInfo instances. Reuses impl when at all possible. Also adds support for bloberizing emphasis marks for text fragments with the addition of a FillTextEmphasisGlyphs StringView/ShapeResult version. BUG=714962 R=kojii@chromium.org Review-Url: https://codereview.chromium.org/2845883002 Cr-Commit-Position: refs/heads/master@{#467592} Committed: https://chromium.googlesource.com/chromium/src/+/67b9f6e761fba98d3a3e80edec863d2b97ff79a5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -34 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.h View 2 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp View 6 chunks +30 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 2 chunks +27 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 2 chunks +59 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
eae
3 years, 7 months ago (2017-04-27 03:23:06 UTC) #1
eae
https://codereview.chromium.org/2845883002/diff/1/third_party/WebKit/Source/platform/graphics/GraphicsContext.h File third_party/WebKit/Source/platform/graphics/GraphicsContext.h (right): https://codereview.chromium.org/2845883002/diff/1/third_party/WebKit/Source/platform/graphics/GraphicsContext.h#newcode240 third_party/WebKit/Source/platform/graphics/GraphicsContext.h:240: void DrawText(const Font&, const TextFragmentPaintInfo&, const FloatPoint&); I tried ...
3 years, 7 months ago (2017-04-27 03:30:32 UTC) #5
kojii
lgtm, great!
3 years, 7 months ago (2017-04-27 03:54:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845883002/1
3 years, 7 months ago (2017-04-27 05:27:57 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 05:33:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67b9f6e761fba98d3a3e80edec86...

Powered by Google App Engine
This is Rietveld 408576698