Chromium Code Reviews
DescriptionNTP: Fix TileType metrics on desktop
Follow-up to https://codereview.chromium.org/2796643002 where the
metrics were added but an inconsistency was introduced between the C++
enum and the Javascript counterpart. This caused the wrong buckets being
counted for NewTabPage.TileType (ThumbnailLocal instead Thumbnail;
ThumbnailServer instead of ThumbnailFailed). The affected buckets
were already deprecated (DeprecatedThumbnailLocal and
DeprecatedThumbnailServer) and hence, luckily, there are no conflated
buckets.
Besides, histograms.xml was missing the new suffixes for
NewTabPageIconTypes, used to provide desktop-specific breakdowns for
NewTabPage.MostVisited and NewTabPage.SuggestionsImpression.
BUG=714095, 703165
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2832173002
Cr-Commit-Position: refs/heads/master@{#467287}
(cherry picked from commit 79eaaf7eefb10a3006da5d1a56007e8c6f72ffe1)
Review-Url: https://codereview.chromium.org/2845863003 .
Cr-Commit-Position: refs/branch-heads/3071@{#261}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/ccbb674bcfe3f1f1395235edd0bb433670a63837
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||